Enable Audio Support for Dasbob Keyboard (Vial)#1
Open
kajigga wants to merge 2 commits into
Open
Conversation
- Enable AUDIO_ENABLE and AUDIO_DRIVER=pwm_hardware in rules.mk - Add AUDIO_PWM_PAL_MODE and AUDIO_PWM_COUNTER_FREQUENCY for RP2040 - Enable RP_PWM_USE_TIM1 in mcuconf.h - Update audio driver to use _impl function pattern - Add audio configuration to vial keymap config.h - Add missing layer definitions (LAYER3-7) to keymap.c - Enable MOUSEKEY, AUTO_SHIFT, COMBOS, REPEAT_KEY, CAPS_WORD - Fix Python 3.14 compatibility (ast.Num -> ast.Constant) - Add audioworking.md documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable Audio Support for Dasbob Keyboard (Vial)
What
This PR enables audio output and audio clicky functionality for the dasbob split keyboard in the Vial firmware. Audio was working in the upstream QMK version but not in Vial.
Why
The Vial fork was missing critical RP2040-specific audio PWM configuration that the QMK version had. Without these settings, the GPIO pin for audio output was not properly configured for PWM, resulting in no sound.
Key Changes
Platform-level fixes:
platforms/chibios/chibios_config.h— AddedAUDIO_PWM_PAL_MODEandAUDIO_PWM_COUNTER_FREQUENCYfor RP2040. WithoutAUDIO_PWM_PAL_MODE, the code fell back to STM32 alternate function mode6which does not work on RP2040.platforms/chibios/drivers/audio_pwm_hardware.c— Updated audio driver to use_implfunction pattern and ISR-safe PWM functions.quantum/audio/audio.{c,h}— Added wrapper functions that call the_implversions.Keyboard-level fixes:
keyboards/dasbob/mcuconf.h— EnabledRP_PWM_USE_TIM1(was commented out)keyboards/dasbob/rules.mk— EnabledAUDIO_ENABLE = yes,AUDIO_DRIVER = pwm_hardware, plus MOUSEKEY, AUTO_SHIFT, COMBOS, REPEAT_KEY, CAPS_WORDkeyboards/dasbob/config.h— AddedFLOW_TAP_TERM,BOTH_SHIFTS_TURNS_ON_CAPS_WORD, and audio pin/driver configkeyboards/dasbob/keymaps/vial/config.h— AddedDYNAMIC_KEYMAP_LAYER_COUNTand audio defineskeyboards/dasbob/keymaps/vial/rules.mk— RemovedVIAL_INSECUREper PR requirementsBuild fix:
lib/python/qmk/math.py— Fixed Python 3.14 compatibility (ast.Num→ast.Constant), required for the build system to work.Testing
Firmware compiles successfully and has been flashed to hardware. Startup sound and audio clicky are now functional.